fix: suppress IL2007 annotations and enable AVIF encoding via libsvtav1enc2 - #318
Merged
Merged
Conversation
…v1enc2 Agent-Logs-Url: https://github.com/winnerspiros/osu/sessions/93be82ca-7d4f-4674-b76a-0758027c1a5f Co-authored-by: winnerspiros <1675249+winnerspiros@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
winnerspiros
May 8, 2026 22:29
View session
There was a problem hiding this comment.
Pull request overview
Reduces build-time noise in the Android APK release workflow by suppressing a benign ILLink warning and ensuring AVIF encoding dependencies are present on the GitHub Actions runner.
Changes:
- Suppress IL2007 in the Android build by adding it to
NoWarninosu.Android.props. - Install
libsvtav1enc2alongsideffmpegin the release workflow to allow AVIF encoding rather than falling back to WebP.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
osu.Android.props |
Adds IL2007 to NoWarn with rationale to prevent benign linker descriptor-validation warnings from producing build annotations. |
.github/workflows/release.yml |
Installs libsvtav1enc2 with ffmpeg so the resource optimizer can encode AVIF as configured. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+227
to
228
| sudo apt-get install -y ffmpeg libsvtav1enc2 | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two build-time noise items in the Android APK workflow: spurious
IL2007annotations from ILLink's descriptor-validation phase, and a "AVIF skipped, falling back to WebP" notice becauselibsvtav1enc2was absent on the runner.Changes
osu.Android.props— AddIL2007to<NoWarn>.SuppressTrimAnalysisWarnings=truealready suppresses IL2xxx during the ILLink trim pass, but IL2007 fires earlier duringLinker.xmldescriptor validation (before the link set is assembled), so it needs an explicit<NoWarn>entry to avoid landing as a build annotation pointing atLinker.xml#L89/#L90.release.yml— Installlibsvtav1enc2alongsideffmpeg.osu-resources-config.jsonhasjpeg_avif_enabled: trueto encode upstream JPEG textures to AVIF. Ubuntu 24.04's aptffmpegis compiled with--enable-libsvtav1but requireslibsvtav1enc2to be installed at runtime. Without it the optimizer silently fell back to WebP for every JPEG inppy/osu-resources.